Refactor: Replace _execute_error() with _execute_or_fail(). #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor has two simple goals: * Simplify control flow: callers no longer need to `if-then-else` themselves, which becomes cumbersome when you have a sequence of calls to `repository_ctx.execute()`. * Improve the output on failure (by listing the failing command).
Profpatsch
reviewed
Nov 13, 2018
| @@ -142,6 +145,26 @@ def nixpkgs_package(*args, **kwargs): | |||
| else: | |||
| _nixpkgs_package(*args, **kwargs) | |||
|
|
|||
| def _execute_or_fail(repository_ctx, arguments, failure_message = "", *args, **kwargs): | |||
There was a problem hiding this comment.
Does *args work after failure_message=? I’m forgot most of the details of this pythonism.
|
0 should always mean success. This convention is followed so universally that I don't think we need to pessimize our code readability just in case. |
Profpatsch
approved these changes
Nov 13, 2018
mboes
added a commit
that referenced
this pull request
Nov 13, 2018
A parenthesis was in the wrong place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor has two simple goals:
if-then-elsethemselves, which becomes cumbersome when you have a sequence of
calls to
repository_ctx.execute().